Silence verify_host_key warning from net-ssh #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintoncwolfe
force-pushed
the
cw/silence-ssh-host-verify-deprecation
branch
4 times, most recently
from
86a8d15 to
20e7017
Compare
marcparadise
approved these changes
Mar 21, 2019
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
clintoncwolfe
force-pushed
the
cw/silence-ssh-host-verify-deprecation
branch
from
20e7017 to
6049ef4
Compare
marcparadise
requested changes
Mar 27, 2019
| 'false' => :never, | ||
| true => :always, | ||
| false => :never, | ||
| # May be correct value, but strings from JSON config |
There was a problem hiding this comment.
Missing the nil case here, since it's possible for someone to specify the option w/ nil value.
There was a problem hiding this comment.
Done, thanks!
| # Likewise, version <5 accepted false; 5+ requires :never or will | ||
| # issue a deprecation warning. This method allows a lot of common | ||
| # things through. | ||
| def verify_host_key_value(given) |
There was a problem hiding this comment.
Should this have tests?
There was a problem hiding this comment.
I've added some, but stubbing the const used to detect the net-ssh version (which affects the mapping, here) proved elusive. So, the tests check whatever net-ssh version is currently being used, which is not ideal.
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
miah
approved these changes
Apr 16, 2019
marcparadise
pushed a commit
to marcparadise/train
that referenced
this pull request
Apr 19, 2019
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
zenspider
added
Aspect: Integration
Component: Logging
Platform: SSH
and removed
Aspect/Integration
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSH transport always wants to disable host key verification. In net-ssh 5+, the acceptable values for verify_host_key changed ;we currently set it to
false, which now results in a deprecation warning fromnet-sshWe already choose what option name to use based on the net-ssh version; this PR now chooses the value dynamically, as well.
As I found when passing values from a config file, there is a good chance the values will come in as Strings, so the PR does some questionable remapping of things to try to catch the common cases.
Signed-off-by: Clinton Wolfe clintoncwolfe@gmail.com