Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a passthrough option for winrm_operation_timeout under winrm #432

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Add a passthrough option for winrm_operation_timeout under winrm #432

merged 1 commit into from
Apr 10, 2019

Conversation

marcparadise
Copy link
Contributor

Signed-off-by: Marc A. Paradise marc.paradise@gmail.com

@marcparadise marcparadise force-pushed the SUSTAIN-955/winrm_operation_timeout branch 2 times, most recently from ca5b598 to 42eb91f Compare April 4, 2019 14:09
@marcparadise marcparadise changed the title Add a passthrough option for ca_trust_file under winrm Add a passthrough option for winrm_operation_timeout under winrm Apr 4, 2019
miah
miah approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcparadise

@marcparadise
Copy link
Contributor Author

Will verify the default timeout in winrm to ensure we're not setting it shorter.

miah
miah previously requested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we've got test failures related to this change.

@marcparadise
Add a passthrough option for operation_timeout under winrm
97a0345 
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise force-pushed the SUSTAIN-955/winrm_operation_timeout branch from 42eb91f to 97a0345 Compare April 5, 2019 15:19
@marcparadise
Copy link
Contributor Author

marcparadise commented Apr 8, 2019 •
edited
Loading

The original failures were related, but the current failures don't seem to be:

  1) Error:
Train::Transports::VMware::Connection::#initialize#test_0003_ignores certificate validation if --insecure is used:
NameError: uninitialized constant Train::Transports::VMware
    /home/travis/build/inspec/train/test/unit/transports/vmware_test.rb:65:in `block (3 levels) in <top (required)>'
  2) Error:
azure transport::azure_client#test_0006_cannot instantiate azure_client vault client without a vault name:
NameError: uninitialized constant Azure::KeyVault
    /home/travis/build/inspec/train/test/unit/transports/azure_test.rb:99:in `block (3 levels) in <top (required)>'
  3) Error:
azure transport::azure_client#test_0005_can use azure_client vault client:
NameError: uninitialized constant Azure::KeyVault
    /home/travis/build/inspec/train/test/unit/transports/azure_test.rb:93:in `block (3 levels) in <top (required)>'

@clintoncwolfe clintoncwolfe dismissed miah’s stale review April 10, 2019 17:30

Tests now pass, was a fluke

@clintoncwolfe clintoncwolfe merged commit 30f3806 into inspec:master Apr 10, 2019
marcparadise added a commit to marcparadise/train that referenced this pull request Apr 19, 2019
@marcparadise
Add a passthrough option for winrm_operation_timeout under winrm (ins…
455009f 
…pec#432)

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsmorrow jonsmorrow jonsmorrow approved these changes

@lamont-granquist lamont-granquist lamont-granquist approved these changes

@miah miah miah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcparadise @miah @lamont-granquist @jonsmorrow @clintoncwolfe