Remove WinRM support in favor of train-winrm plugin #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintoncwolfe
added
Type: Deprecation
zenspider
suggested changes
May 10, 2019
clintoncwolfe
force-pushed
the
cw/remove-winrm
branch
from
859c3ab to
a89b470
Compare
tas50
reviewed
May 10, 2019
tas50
changed the title
tas50
previously requested changes
May 10, 2019
zenspider
approved these changes
May 10, 2019
miah
approved these changes
Jun 2, 2019
|
This one needs a rebase. |
clintoncwolfe
force-pushed
the
cw/remove-winrm
branch
from
d17e4c5 to
008192f
Compare
clintoncwolfe
added
Expeditor/Bump Major Version
and removed
Expeditor/Bump Minor Version
labels
This was referenced Aug 2, 2019
clintoncwolfe
force-pushed
the
cw/remove-winrm
branch
from
008192f to
4f035fc
Compare
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
clintoncwolfe
force-pushed
the
cw/remove-winrm
branch
from
4f035fc to
a4567be
Compare
|
Code Climate has analyzed commit e268f73 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
1 task
zenspider
added
Component: Plugin API
Expeditor: Bump Major Version
Platform: WinRM
and removed
Component/Plugin API
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes WinRM support from the core of train, in favor of using it via the train-winrm plugin. Be sure to update your dependencies to include train-winrm.
As one of the major themes of Train 2 is pushing transports into plugins for lighter packaging, we're only doing a minor version bump on this.As this will break any user of train that relies on winrm, good semver discipline would be to do a major version bump.