Rename ca_trust_file to ca_trust_path #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
changed the title
10 tasks
marcparadise
force-pushed
the
use-correct-ca-trust-name
branch
from
4402b59 to
2bae9dc
Compare
|
I've updated this with a check of default, but I couldn't find a meaningful way to verify that it's getting passed through to WinRMConnection - the only locations to validate it are private. |
WinRM expects `ca_trust_file` not `ca_trust_path` Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
force-pushed
the
use-correct-ca-trust-name
branch
from
2bae9dc to
1631a4d
Compare
|
In the category of 'iffy is better than nothing'... I added validations for the configuration we're passing into |
miah
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinRM expects
ca_trust_pathnotca_trust_fileSigned-off-by: Marc A. Paradise marc.paradise@gmail.com