Apply Chefstyle to train #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
reviewed
May 25, 2019
| gem 'm' | ||
| gem "coveralls", require: false | ||
| gem "minitest", "~> 5.8" | ||
| gem "rake", "~> 10" |
There was a problem hiding this comment.
Any reason not to just remove the pin here and let this float?
clintoncwolfe
approved these changes
May 28, 2019
|
I'm going to hold on merging this for now as I want to see if I can figure out why a few of these tests are still failing. I had some insights while flying home after chefconf. Will resume those today =) |
|
There are too many results to compare View more on Code Climate. |
We are defining a reader named #path here, but also define #path on line 75. Signed-off-by: Miah Johnson <miah@chia-pet.org>
Signed-off-by: Miah Johnson <miah@chia-pet.org>
Signed-off-by: Miah Johnson <miah@chia-pet.org>
Signed-off-by: Miah Johnson <miah@chia-pet.org>
Signed-off-by: Miah Johnson <miah@chia-pet.org>
Signed-off-by: Miah Johnson <miah@chia-pet.org>
Signed-off-by: Miah Johnson <miah@chia-pet.org>
|
Back to green! |
zenspider
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sync's the train repo with the centralized chefstyle used by all Chef projects.