Use /etc/os-release for SUSE detection (Adopted) #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the windows test into it's own block since it's not part of the set of debian tests. Signed-off-by: Russell Cardullo <russellcardullo@gmail.com>
The /etc/SuSE-release file was deprecated in older SUSE versions and as of openSUSE/SLES 15.X is no longer present on these systems. This changes the detection methods to use /etc/os-release which should be present on new as well as older systems. Signed-off-by: Russell Cardullo <russellcardullo@gmail.com>
Older versions of SUSE won't have the /etc/os-release file so fallback to the /etc/SuSE-release file in those cases. Signed-off-by: Russell Cardullo <russellcardullo@gmail.com>
…rain into cw/update-suse-detection
|
Code Climate has analyzed commit 38feb25 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
4 tasks
miah
approved these changes
Aug 6, 2019
zenspider
reviewed
Aug 6, 2019
| # https://rubular.com/r/xegcPXKEXJrJl5 | ||
| version = suse[/VERSION *= *("?)([\d\.]{2,})\1$/, 2] if version == "" | ||
| # https://rubular.com/r/b5PN3hZDxa5amV | ||
| version = suse[/VERSION\s?=\s?"?([\d\.]{2,})"?/, 1] if version == "" |
There was a problem hiding this comment.
Why did this go backwards?
myii
added a commit
to myii/postgres-formula
that referenced
this pull request
Aug 20, 2019
myii
added a commit
to myii/postgres-formula
that referenced
this pull request
Aug 20, 2019
myii
added a commit
to myii/postgres-formula
that referenced
this pull request
Aug 28, 2019
zenspider
added
Component: Platform Detection
Platform: UNIX-Like
and removed
Component/Platform Detection
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adoption of #476, for rebasing. Following is the original PR description.
Description
The file
/etc/SuSE-releasewas deprecated in older SUSE versions and as of SUSE/SLES 15.X is no longer present. This switches the detection to use the values in/etc/os-release.Related Issue
Fixes #377
Types of changes
Checklist: