Fix raise invalid arguments #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Kernel#raise takes caller string array as a third argument - But it appeared `reason` String passed while raising an error. - Reference https://ruby-doc.org/core-2.6.3/Kernel.html#method-i-raise Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
|
Code Climate has analyzed commit 416cf28 and detected 0 issues on this pull request. View more on Code Climate. |
kvivek1115
changed the title
zenspider
approved these changes
Aug 13, 2019
| msg, reason = verification_res | ||
| raise Train::UserError, "Sudo failed: #{msg}", reason | ||
| msg, _reason = verification_res | ||
| raise Train::UserError, "Sudo failed: #{msg}" |
There was a problem hiding this comment.
Wow. Good find... but that verify method is just a mess and should be cleaned up (in a different PR). Returning nil or a string or an array of a string or a symbol is not right. I'll file a separate issue against that. Thank you.
There was a problem hiding this comment.
@zenspider, will cleanup verify method thanks!
This was referenced Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed improper error msg raised
backtrace must be Array of String (TypeError)Before Fix:
After Fix:
Description
reasonString passed while raising an error.Related Issue
#506
Types of changes
Checklist:
Signed-off-by: Vivek Singh vivek.singh@msystechnologies.com