Ensure UserError is raised with a reason value #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the issue fixed in 416cf28; however that commit discarded the reason attached to the exception. This should be kept, since Train::UserError covers a lot of ground and the reason code can help clients differentiate cause without resorting to their own parsing of error string. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
Code Climate has analyzed commit 50a8724 and detected 0 issues on this pull request. View more on Code Climate. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the issue fixed in
416cf28; however that commit
discarded the reason attached to the exception. This should be kept,
since Train::UserError covers a lot of ground and the reason
code can help clients differentiate cause without resorting to
their own parsing of error string.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com
Description
Related Issue
Types of changes
Checklist: