Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powershell detection #523

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Add powershell detection #523

merged 2 commits into from
Oct 9, 2019

Conversation

miah
Copy link
Contributor

@miah miah commented Oct 8, 2019

Fixes: #518

@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Oct 8, 2019

Hello miah! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Signed-off-by: Miah Johnson <miah@chia-pet.org>
Copy link
Contributor

@zenspider zenspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHERE IS THE POWERSHELL TEST?!?!?

😛

Signed-off-by: Miah Johnson <miah@chia-pet.org>
@codeclimate
Copy link

codeclimate bot commented Oct 8, 2019

Code Climate has analyzed commit a4db189 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Style 4

View more on Code Climate.

@miah miah requested a review from zenspider October 8, 2019 22:26
Copy link
Contributor

@zenspider zenspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already approved since we paired. 😛

@miah miah merged commit 5f5b4b3 into master Oct 9, 2019
@chef-expeditor chef-expeditor bot deleted the mj/ps branch October 9, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InSpec / Train stacktraces on Windows/Habitat
3 participants