Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributor url pointing to 404 #532

Conversation

kvivek1115
Copy link

@kvivek1115 kvivek1115 commented Nov 6, 2019

Description

Link [Fletcher Nichol](fnichol@nichol.ca) of README content converted into https://github.com/inspec/train/blob/master/fnichol@nichol.ca which seems taking related to repo URL.

So appended mailto ie. [Fletcher Nichol](mailto:fnichol@nichol.ca)

Ref: https://github.com/fnichol

* [test-kitchen](https://github.com/test-kitchen/test-kitchen)

    by [Fletcher Nichol](fnichol@nichol.ca)
    and [a great community of contributors](https://github.com/test-kitchen/test-kitchen/graphs/contributors)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Vivek Singh vivek.singh@msystechnologies.com

Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Nov 6, 2019

Hello vsingh-msys! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@codeclimate
Copy link

codeclimate bot commented Nov 6, 2019

Code Climate has analyzed commit c78a449 and detected 0 issues on this pull request.

View more on Code Climate.

@miah miah merged commit f2e230e into inspec:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants