Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added create_github_release action to stable promotion. #536

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

zenspider
Copy link
Contributor

It hasn't been done since 2017. :(

Signed-off-by: Ryan Davis zenspider@chef.io

It hasn't been done since 2017. :(

Signed-off-by: Ryan Davis <zenspider@chef.io>
@zenspider zenspider requested a review from a team as a code owner November 21, 2019 23:13
@ghost ghost requested review from clintoncwolfe and miah November 21, 2019 23:14
@chef-expeditor
Copy link
Contributor

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@codeclimate
Copy link

codeclimate bot commented Nov 21, 2019

Code Climate has analyzed commit 8df45c5 and detected 0 issues on this pull request.

View more on Code Climate.

@zenspider zenspider merged commit 2987bb7 into master Nov 22, 2019
@chef-expeditor chef-expeditor bot deleted the zenspider/expeditor/github-releases branch November 22, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants