Revert to regular require to fix transport loading across gem boundary #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
|
Code Climate has analyzed commit c9c5c72 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
btm
approved these changes
Feb 14, 2020
| require "ms_rest_azure" | ||
| require "azure_mgmt_resources" | ||
| require "azure_graph_rbac" | ||
| require "azure_mgmt_key_vault" | ||
| require "socket" | ||
| require "timeout" | ||
| require_relative "helpers/azure/file_credentials" | ||
| require_relative "clients/azure/graph_rbac" | ||
| require_relative "clients/azure/vault" |
There was a problem hiding this comment.
I don't think you need these three because they're in the glob but 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Clinton Wolfe clintoncwolfe@gmail.com
Fixes inspec/inspec-azure#234 .
You can't require_relative a file when it is contained in a separate gem. So, our train-core / train split means we need to
requirethese bundled files.Description
Related Issue
Types of changes
Checklist: