Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid explicit /tmp in favor of $TMPDIR #578

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Avoid explicit /tmp in favor of $TMPDIR #578

merged 1 commit into from
Mar 11, 2020

Conversation

majioa
Copy link
Contributor

@majioa majioa commented Mar 6, 2020

Signed-off-by: Malo Skrylevo majioa@yandex.ru

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@majioa majioa requested a review from a team as a code owner March 6, 2020 12:44
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Mar 6, 2020

Hello majioa! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@@ -1,22 +1,22 @@
#!/bin/sh
test ! -e /tmp/folder && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we want to start this file with a quick check for the existence of TMPDIR, defaulting it to /tmp/ if it doesn't otherwise exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added changes

Signed-off-by: Malo Skrylevo <majioa@yandex.ru>
Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me!

@stevendanna stevendanna merged commit f50d53c into inspec:master Mar 11, 2020
@majioa
Copy link
Contributor Author

majioa commented Mar 11, 2020

@stevendanna thanx , please make patch release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants