Bump Chefstyle and ready for dependabot #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the gemfile.local sourcing which dependabot can't work with. This way we'll get nice PRs to bump deps including CVEs complete with changelogs showing us what's changed. Signed-off-by: Tim Smith <tsmith@chef.io>
|
Hello tas50! Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
Schwad
reviewed
May 11, 2020
| @@ -54,7 +54,7 @@ def initialize(options) | |||
| @bastion_user = @options.delete(:bastion_user) | |||
| @bastion_port = @options.delete(:bastion_port) | |||
|
|
|||
| @cmd_wrapper = CommandWrapper.load(self, @transport_options) | |||
| @cmd_wrapper = CommandWrapper.load(self, @transport_options) | |||
There was a problem hiding this comment.
It looks relatively straightforward to me but I'll leave officially approval to someone on the core team who has had more time in train code than me. Quick question, was this a stylistic change?
There was a problem hiding this comment.
It satisfies a cop in the current ChefStyle:
lib/train/transports/ssh_connection.rb:57:31: C: Layout/SpaceAroundOperators: Operator = should be surrounded by a single space.
Alternatively the indenting can be kept and the blank line at line 56 deleted - that also satisfies the cop.
This current form looks correct to me as this @cmd_wrapper isn't quite the same as the indented option passing lines above it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the gemfile.local sourcing which dependabot can't work with. This
way we'll get nice PRs to bump deps including CVEs complete with
changelogs showing us what's changed.
Signed-off-by: Tim Smith tsmith@chef.io