Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect error message when password is expired #616

Merged
merged 5 commits into from
Jul 1, 2020

Conversation

kvivek1115
Copy link

Description

I have come across a scenario where the AIX system password got expired due to this getting platform detention error which is wrong. Fixes provide an exact error message to the user so that, action should be taken accordingly.

Related Issue

Fixes: #615

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Vivek Singh vivek.singh@msystechnologies.com

Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
@kvivek1115 kvivek1115 requested a review from a team as a code owner June 25, 2020 10:23
@chef-expeditor
Copy link
Contributor

Hello vsingh-msys! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Vivek Singh added 3 commits June 26, 2020 09:16
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
@kvivek1115 kvivek1115 force-pushed the VSingh/fix-wrong-error-msg branch from 00cf8cf to 156acb0 Compare June 26, 2020 11:22
Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
Copy link

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the help @vsingh-msys ! 👍

Copy link

@james-stocks james-stocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vsingh-msys :)

@tas50 tas50 changed the title Fixes wrong error message when password got expired Fixes wrong error message when password is expired Jul 1, 2020
@tas50 tas50 changed the title Fixes wrong error message when password is expired Fix incorrect error message when password is expired Jul 1, 2020
@tas50 tas50 merged commit aab2a90 into inspec:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid error Train::PlatformDetectionFailed when AIX password has expired.
4 participants