Support unpacking train options from URI query values #642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple to support arbitrary options in URIs so that stuff like
ssh://user:pass@host.com:123/path?bastion_host=stronghold.example.org&bastion_user=bulwark
becomes valid. This came up as a result of the work in chef/ohai#1503 to support ohai over train and to allow passing a URL into ohai with the--target
option on the command line such that it doesn't require the presence of a.chef/crendentials
file.