Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unpacking train options from URI query values #642

Merged
merged 3 commits into from
Dec 7, 2020

Conversation

lamont-granquist
Copy link
Contributor

Pretty simple to support arbitrary options in URIs so that stuff like ssh://user:pass@host.com:123/path?bastion_host=stronghold.example.org&bastion_user=bulwark becomes valid. This came up as a result of the work in chef/ohai#1503 to support ohai over train and to allow passing a URL into ohai with the --target option on the command line such that it doesn't require the presence of a .chef/crendentials file.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@chef-expeditor
Copy link
Contributor

Hello lamont-granquist! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

transform_keys not available in 2.4

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist
Copy link
Contributor Author

paging @clintoncwolfe and @Schwad for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants