Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ssh config file by default #713

Merged
merged 5 commits into from
Dec 17, 2021

Conversation

Vasu1105
Copy link
Contributor

@Vasu1105 Vasu1105 commented Dec 16, 2021

Signed-off-by: Vasu1105 vasundhara.jagdale@chef.io

Description

The Net::SSH config option set true by default https://www.rubydoc.info/github/net-ssh/net-ssh/Net/SSH. So it is required to set the ssh_config_file newly added option to true to keep earlier behavior.

Related Issue

#709
Fixes #712

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
@Vasu1105 Vasu1105 requested a review from a team as a code owner December 16, 2021 15:55
@clintoncwolfe clintoncwolfe changed the title Update ssh_config_file option default to true. Use ssh config file by default Dec 16, 2021
…y breaking when we run bundle exec rake on Windows. Individual running of the test files working correctly on the Windows.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
…he functionality

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
…nfig file which was not working due to regression. Also added missing code comments.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
…-absolute home on bundle exec rake run

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
@Vasu1105 Vasu1105 force-pushed the vasundhara/fix_ssh_config_option_default_value branch from be992c8 to 1b75b89 Compare December 17, 2021 18:11
@clintoncwolfe clintoncwolfe merged commit 2034992 into main Dec 17, 2021
@clintoncwolfe clintoncwolfe deleted the vasundhara/fix_ssh_config_option_default_value branch December 17, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Train::Transports::SSH v3.8.5
2 participants