Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Cisco devices being detected as Arista #736

Merged

Conversation

trickyearlobe
Copy link

  • Some Cisco devices are being mis-detected as Arista devices from show version command
  • Added a conditional to the Arista declare_instance to make sure that calls to show version contain Arista

Signed-off-by: Richard Nixon richard.nixon@btinternet

Description

When running inspec detect -t ssh://nexus001 against a virtual Nexus 9300 (NXOS) the platform was being mis-detected as Arista EOS with no version number.

After applying this bugfix, virtual Nexus and virtual Arista devices are correctly detected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@trickyearlobe trickyearlobe requested a review from a team as a code owner September 2, 2022 13:53
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Sep 2, 2022

Hello trickyearlobe! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

- Some Cisco devices are being mis-detected as Arista devices from `show version` command
- Added a conditional to the Arista `declare_instance` to make sure that calls to `show version` contain `Arista`

Signed-off-by: Richard Nixon <richard.nixon@btinternet>
@trickyearlobe trickyearlobe force-pushed the fix_cisco_getting_detected_as_arista branch from 2c15e83 to dc8cf87 Compare September 2, 2022 15:10
@clintoncwolfe clintoncwolfe merged commit 80f2fe6 into inspec:main Sep 30, 2022
@trickyearlobe trickyearlobe deleted the fix_cisco_getting_detected_as_arista branch January 24, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants