Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cisco Nexus version detection #737

Merged

Conversation

trickyearlobe
Copy link

The format of the output from show version has changed in Cisco NXOS 9.3
and requires a different regex to match it.

Tested on 9.3(10) virtual Nexus 9300

Signed-off-by: Richard Nixon richard.nixon@btinternet

Description

Added a new regex to extract the version number for Cisco Nexus switches

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

The format of the output from `show version` has changed in 9.3
and requires a different regex to match it.

Tested on 9.3(10) virtual Nexus 9300

Signed-off-by: Richard Nixon <richard.nixon@btinternet>
@trickyearlobe trickyearlobe requested a review from a team as a code owner September 2, 2022 15:53
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Sep 2, 2022

Hello trickyearlobe! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@clintoncwolfe clintoncwolfe merged commit 673ec99 into inspec:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants