Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cannot find a UUID when connect using train with local transport inside docker container #747

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix cannot find a UUID when connect using train with local transport inside docker container #747

merged 1 commit into from
Jun 23, 2023

Conversation

Vasu1105
Copy link
Contributor

@Vasu1105 Vasu1105 commented Jun 23, 2023 •
edited by clintoncwolfe
Loading

Description

When running Train using local transport insider docker container it enables to find the UUID.

Previously, that would raise an error Cannot find a UUID because all UUID finding method would fail.

This was breaking inspec CI tests under Ruby 3.1 - https://buildkite.com/chef-oss/inspec-inspec-inspec-6-verify/builds/216#0188e7c9-2312-4857-87a8-7d0d67f4673f

This solution is currently only for docker containers.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@Vasu1105 Vasu1105 requested a review from a team as a code owner June 23, 2023 07:30
@Vasu1105
This includes one more way to find the uuid in local transport runnin…
21e7039 
…g inside docker container

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
@Vasu1105 Vasu1105 force-pushed the vasundhara/fix-uuid-for-local-transport-running-inside-docker-container branch from db77a93 to 21e7039 Compare June 23, 2023 07:37
@Vasu1105 Vasu1105 changed the title [WIP] Fix cannot find a UUID when connect using train with local transport inside docker container Fix cannot find a UUID when connect using train with local transport inside docker container Jun 23, 2023
clintoncwolfe
clintoncwolfe approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's regrettable that this is Docker-specific to start, but we need to get a fix into the CI system ASAP. Other runtimes will continue to report no UUID.

@clintoncwolfe clintoncwolfe merged commit 0b6dc3c into main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@ahasunos ahasunos Awaiting requested review from ahasunos ahasunos is a code owner automatically assigned from inspec/inspec-core-team

Assignees

@Vasu1105 Vasu1105

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vasu1105 @clintoncwolfe