-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHEF-6440(CHEF-7426): Adds audit log support #749
Conversation
cb52bc4
to
99bda39
Compare
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
99bda39
to
a793882
Compare
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
0dbc3db
to
0d9ec3d
Compare
…rom audit logger as it is not required which makes it dynamic Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
af1cf18
to
079a5f7
Compare
…creating train transport and before creating connection Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
…time of creating train transport and before creating connection" This reverts commit b7e707b.
# should we keep it to $stdout. | ||
{ | ||
enable_audit_log: { default: false }, | ||
audit_log_location: { required: true, default: nil }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, yeah, that required: true broke all the tests. We can compromise.
How about set it to a path like ~/.chef/logs/train-audit.log - Use a peculiar train-specific default, and any reasonable application would have to override it. Does that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clintoncwolfe I think we can keep the required. We are able to separate our validation implementation for the audit log from the existing validate_option method, and we separated the audit log options from the current default_options so that those can be handled separately. This I think will make this change less breaking.
…ic to merge the audit log options in default_options hash and keep the audit log options in sperated from the existing default options. This make sure it should not break existing behavior of any train plugin Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
This reverts commit 0d9ec3d.
…log option Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
2156ea3
to
ccca06c
Compare
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
7f1eac4
to
ebbe953
Compare
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
ebbe953
to
1124cd9
Compare
4ab5c53
to
30a4f5a
Compare
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
30a4f5a
to
ccfb41e
Compare
This reverts commit ccfb41e.
… the transport for validation Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
…e, making it unreadable to JSON Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
Description
This PR adds the ability to configure the audit log option using train and if the audit log is enabled it generates the audit log files in the default location.
This includes the following changes
enable_audit_log
option totrue
while creating train transport to enable it.Test using irb
audit_log_location is a required parameter so any library or plugin using train to pass the audit log location be they want to enable the audit log.
Pending: dev-docs
Related Issue
Types of changes
Checklist: