-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gem: pin down googleauth gem to below 1.9 #773
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
ahasunos
force-pushed
the
ss/pin-down-googleauth
branch
from
April 15, 2024 09:34
0829b3a
to
a66e61e
Compare
Vasu1105
approved these changes
Apr 15, 2024
The intuition behind pinning googleauth below 1.9 is that the CI is failing with the following stacktrace on Windows Click to see the stacktrace
This arises from the method: which was updated in PR: googleapis/google-auth-library-ruby#459 Hence, using a version which doesn't include the changes in this method. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses recent CI failures on Windows caused by changes in googleauth gem's method https://github.com/googleapis/google-auth-library-ruby/blob/8f127eee40b0f970706c59cb324f71408dd2fec4/lib/googleauth/compute_engine.rb#L72 . To restore stability to our CI pipelines, we're pinning the googleauth gem to version below 1.9 in our gemspec.
Related Issue
Types of changes
Checklist: