[Refactor] objEquiv: bail early if typeofs are different

inspect-js · Sep 23, 2014 · 410e2d6 · 410e2d6
1 parent 0c5b21a
commit 410e2d6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -52,6 +52,7 @@ function isBuffer(x) {
 function objEquiv(a, b, opts) {
   /* eslint max-statements: [2, 50] */
   var i, key;
+  if (typeof a !== typeof b) { return false; }
   if (isUndefinedOrNull(a) || isUndefinedOrNull(b)) { return false; }
 
   // an identical 'prototype' property.

diff --git a/test/cmp.js b/test/cmp.js
@@ -316,3 +316,15 @@ test('arrays and objects', function (t) {
 
   t.end();
 });
+
+test('functions', function (t) {
+  function f() {}
+
+  t.ok(equal(f, f), 'a function is equal to itself');
+  t.ok(equal(f, f, { strict: true }), 'strict: a function is equal to itself');
+
+  t.notOk(equal(function () {}, function () {}), 'two different functions are never equal');
+  t.notOk(equal(function () {}, function () {}, { strict: true }), 'strict: two different functions are never equal');
+
+  t.end();
+});