[Refactor] there is no need to do further compareation when two types…

… are not equal
inspect-js · Jan 20, 2017 · 6a5efc1 · 6a5efc1
1 parent 28fde4a
commit 6a5efc1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -6,6 +6,7 @@
     "eqeqeq": 1,
     "func-style": [2, "declaration"],
     "indent": [2, 2],
+    "max-lines-per-function": [2, 75],
     "max-params": [2, 3],
     "strict": 1,
   },

diff --git a/index.js b/index.js
@@ -15,7 +15,7 @@ function deepEqual(actual, expected, options) {
   }
 
   // 7.3. Other pairs that do not both pass typeof value == 'object', equivalence is determined by ==.
-  if (!actual || !expected || (typeof actual != 'object' && typeof expected != 'object')) {
+  if (!actual || !expected || (typeof actual !== 'object' && typeof expected !== 'object')) {
     return opts.strict ? is(actual, expected) : actual == expected;
   }
 
@@ -79,6 +79,10 @@ function objEquiv(a, b, opts) {
     return true;
   }
 
+  if (typeof a !== typeof b) {
+    return false;
+  }
+
   try {
     var ka = objectKeys(a);
     var kb = objectKeys(b);
@@ -107,7 +111,7 @@ function objEquiv(a, b, opts) {
     }
   }
 
-  return typeof a === typeof b;
+  return true;
 }
 
 module.exports = deepEqual;