Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null should be == undefined in non-strict mode #23

Closed
isaacs opened this issue Jul 29, 2015 · 0 comments
Closed

null should be == undefined in non-strict mode #23

isaacs opened this issue Jul 29, 2015 · 0 comments

Comments

@isaacs
Copy link
Contributor

isaacs commented Jul 29, 2015

Because https://github.com/substack/node-deep-equal/blob/master/index.js#L16-L17 tests for typeof !== 'object', this fails to account for the fact that null == undefined (since typeof null === 'object'), resulting in a surprising situation.

See: tapjs/tapjs#155

Would you be open to a PR that addressed this?
isaacs added a commit to isaacs/node-deep-equal that referenced this issue Jul 29, 2015
@isaacs
Null should == undefined
962fa75 
But only in non-strict mode.

Fix inspect-js#23
@isaacs isaacs mentioned this issue Jul 29, 2015
Merged
isaacs added a commit to tapjs/tapjs that referenced this issue Aug 28, 2015
@isaacs
Use patched deep-equal for now
994b64b 
Fix #155 until inspect-js/node-deep-equal#23 lands
@ghost ghost closed this as completed in #24 Aug 29, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isaacs