Fix invalid strict-mode syntax with hexadecimal #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my comment here: ssbc/ssb-server#683 (comment) |
ljharb
requested changes
Jul 27, 2019
|
I'll be adding eslint to this repo, which will end up subsuming this PR, so I'll reopen and update the PR with those commits. |
ljharb
approved these changes
Jul 27, 2019
|
Thank you for the merge! |
ljharb
added a commit
that referenced
this pull request
Nov 10, 2019
- [New] add support for `WeakMap` and `WeakSet` - [Refactor] add early bailout to `isMap` and `isSet` checks - [meta] add `funding` field - [meta] add copyright to LICENSE (#21) - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `core-js`, `tape` - [Tests] use shared travis-ci configs - [Tests] use `npx aud` in `posttest` - [Tests] Fix invalid strict-mode syntax with hexadecimal (#22) - [Tests] add linting
ljharb
added a commit
that referenced
this pull request
Nov 11, 2019
- [New] add support for `WeakMap` and `WeakSet` - [Refactor] add early bailout to `isMap` and `isSet` checks - [meta] add `funding` field - [meta] add copyright to LICENSE (#21) - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `core-js`, `tape` - [Tests] use shared travis-ci configs - [Tests] use `npx aud` in `posttest` - [Tests] Fix invalid strict-mode syntax with hexadecimal (#22) - [Tests] add linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where the module wasn't able to be parsed in strict mode.
See: ssbc/ssb-server#683