Closes #1280 - Closing inspectIT class loader when the agent is shutting down

[mariusoe]

closes #1280

---

This change is 

[codecov]

Codecov Report

Merging #1281 (2273a47) into master (d37a7dc) will decrease coverage by 2.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1281      +/-   ##
============================================
- Coverage     83.00%   80.70%   -2.31%     
- Complexity     1736     2026     +290     
============================================
  Files           174      204      +30     
  Lines          5366     6466    +1100     
  Branches        650      769     +119     
============================================
+ Hits           4454     5218     +764     
- Misses          675      957     +282     
- Partials        237      291      +54     

Impacted Files	Coverage Δ
...spectit/ocelot/core/utils/WeakMethodReference.java	0.00% <0.00%> (-77.27%)	⬇️
...strap/correlation/noop/NoopLogTraceCorrelator.java	28.57% <0.00%> (-42.86%)	⬇️
...ial/ScheduledExecutorContextPropagationSensor.java	82.05% <0.00%> (-12.39%)	⬇️
...in/java/rocks/inspectit/ocelot/core/AgentImpl.java	63.27% <0.00%> (-10.54%)	⬇️
...pectit/ocelot/config/loaders/ConfigFileLoader.java	82.61% <0.00%> (-8.70%)	⬇️
...lot/bootstrap/context/noop/NoopContextManager.java	10.00% <0.00%> (-6.67%)	⬇️
...core/instrumentation/InstrumentationTriggerer.java	85.19% <0.00%> (-5.63%)	⬇️
...t/ocelot/config/validation/PropertyPathHelper.java	75.56% <0.00%> (-5.06%)	⬇️
...rocks/inspectit/ocelot/config/utils/CaseUtils.java	90.48% <0.00%> (-4.98%)	⬇️
...t/ocelot/core/instrumentation/hook/MethodHook.java	95.35% <0.00%> (-4.65%)	⬇️
... and 96 more

[heiko-holz]

Reviewed 6 of 7 files at r1.
Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @heiko-holz and @mariusoe)

---

inspectit-ocelot-agent/src/main/java/rocks/inspectit/ocelot/agent/AgentMain.java, line 61 at r1 (raw file):

        try {
            if (loadOpenCensusToBootstrap) {
                Path ocJarFile = copyResourceToTempJarFile(OPENCENSUS_FAT_JAR_PATH, "opencensus-fat-");

wouldn't it be more suitable to have private static final String OPENCENSUS_FAT_JAR_TEMP_PREFIX variables (also for bootstrap and core?)

---

inspectit-ocelot-agent/src/main/java/rocks/inspectit/ocelot/agent/AgentMain.java, line 102 at r1 (raw file):

        if (includeOpenCensus) {
            Path ocJarFile = copyResourceToTempJarFile(OPENCENSUS_FAT_JAR_PATH, "ocelot-oc-fat-");

why does this prefix differ to the one used above for OPENCENSUS_FAT_JAR_PATH?

[mariusoe]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @heiko-holz)

---

inspectit-ocelot-agent/src/main/java/rocks/inspectit/ocelot/agent/AgentMain.java, line 61 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

wouldn't it be more suitable to have private static final String OPENCENSUS_FAT_JAR_TEMP_PREFIX variables (also for bootstrap and core?)

Done.

---

inspectit-ocelot-agent/src/main/java/rocks/inspectit/ocelot/agent/AgentMain.java, line 102 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

why does this prefix differ to the one used above for OPENCENSUS_FAT_JAR_PATH?

Done.

[mariusoe]

Reviewed 6 of 7 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @heiko-holz)

[heiko-holz]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mariusoe)