-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inspectit-ocelot-demo from repository #1384
Remove inspectit-ocelot-demo from repository #1384
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
============================================
+ Coverage 80.98% 81.04% +0.06%
Complexity 2071 2071
============================================
Files 211 211
Lines 6593 6593
Branches 782 782
============================================
+ Hits 5339 5343 +4
+ Misses 955 951 -4
Partials 299 299
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 51 of 52 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aaronweissler)
inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 9 at r2 (raw file):
## inspectIT Ocelot Demo If you would like to check inspectIT Ocelot in action with a demo application, you can use our docker compose example.
Add link to the directory/repo of the docker demo in https://github.com/inspectIT/inspectit-ocelot-demo.
The appropriate directory (spring-petclinic-docker-demo
) will be available soon.
inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 84 at r2 (raw file):
Details on accessing monitoring infrastructure components are listed below, depending on the selected demo scenario. ### Starting the Demo on Windows Using WSL
Why was this text block removed?
Is the problem solved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 51 of 52 files reviewed, all discussions resolved (waiting on @heiko-holz)
inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 84 at r2 (raw file):
Previously, heiko-holz (Heiko Holz) wrote…
Why was this text block removed?
Is the problem solved?
We agreed on adding the note that this work around is only needed in some Docker Desktop version with WSL 1
inspectIT Ocelot's demos now reside in their own repository at https://github.com/inspectIT/inspectit-ocelot-demo, so the folder containing it is removed and references to it are updated with this PR.
This change is