Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve agent mappings page #1639

Merged
merged 7 commits into from
Jan 15, 2024
Merged

improve agent mappings page #1639

merged 7 commits into from
Jan 15, 2024

Conversation

EddeCCC
Copy link
Member

@EddeCCC EddeCCC commented Jan 10, 2024

Add progress spinner for AgentMapping-UI and cache agent mappings


This change is Reviewable

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (986a6bb) 78.53% compared to head (64b1688) 78.54%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1639      +/-   ##
============================================
+ Coverage     78.53%   78.54%   +0.01%     
- Complexity     2578     2582       +4     
============================================
  Files           266      267       +1     
  Lines          8453     8468      +15     
  Branches        997      999       +2     
============================================
+ Hits           6638     6651      +13     
- Misses         1379     1382       +3     
+ Partials        436      435       -1     
Files Coverage Δ
...g/conversion/InspectitConfigConversionService.java 94.12% <87.50%> (-5.88%) ⬇️
...tit/ocelot/core/config/PropertyNamesValidator.java 75.00% <50.00%> (-3.26%) ⬇️
...fig/conversion/PlaceholderToDurationConverter.java 50.00% <50.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@TitusLabs TitusLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 12 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EddeCCC)

@EddeCCC EddeCCC merged commit 7b2abd2 into master Jan 15, 2024
17 checks passed
@EddeCCC EddeCCC deleted the patch-mapping-promotion branch January 31, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants