Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM package for Swift 5.3 #65

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

kristiyandobrev
Copy link
Contributor

Adding Swift 5.3 specific SPM package without breaking compatibility for iOS 8.

Fixes Xcode 12 warning mentioned here 👉 #64

@Kaspik
Copy link

Kaspik commented Oct 7, 2020

@ngocholo Hey! Any chance we could merge this in? :)

Copy link
Contributor

@ngoleo ngoleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! @kristiyandobrev

@ngoleo ngoleo merged commit 4a47393 into instacart:master Oct 7, 2020
@Kaspik
Copy link

Kaspik commented Oct 7, 2020

@ngocholo Any chance you could ship it as 0.1.2 (at least the tag on github for SPM) so we don§t have to point to master? :) Thanks!

@kristiyandobrev kristiyandobrev deleted the xcode-12-swift5.3-warning branch October 12, 2020 06:23
@ngoleo
Copy link
Contributor

ngoleo commented Nov 10, 2020

@Kaspik 0.1.2 has been released.

@raymondjoneskustomer
Copy link

@ngoleo iOS 8 support is not officially dropped until you bump the ios version in your podspec file. The newest release still sees this:

{
  "name": "Nantes",
  "version": "0.1.2",
  "summary": "A swift replacement of TTTAttributedLabel",
  "description": "Nantes is a swift replacement of TTTAttributedLabel.",
  "homepage": "https://github.com/Instacart/Nantes",
  "license": {
    "type": "Apache 2.0",
    "file": "LICENSE"
  },
  "authors": {
    "chansen22": "chris.hansen@instacart.com"
  },
  "source": {
    "git": "https://github.com/Instacart/Nantes.git",
    "tag": "0.1.2"
  },
  "platforms": {
    "ios": "8.0"
  },
  "source_files": "Source/Classes/**/*",
  "swift_versions": "5.0",
  "frameworks": "UIKit",
  "swift_version": "5.0"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants