Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty response now triggers json exception (1.4.4) #78

Closed
tractorcow opened this issue Jun 29, 2017 · 1 comment
Closed

Empty response now triggers json exception (1.4.4) #78

tractorcow opened this issue Jun 29, 2017 · 1 comment

Comments

@tractorcow
Copy link
Contributor

We've discovered a critical breakage in our behat CI caused by the recent 1.4.4 release.

I've traced this to #67.

An example broken build can be seen at https://travis-ci.org/silverstripe/silverstripe-framework/jobs/248559035

Our selenium server log shows the requests being passed through to it without any apparent error.

10:32:36.017 INFO - Done: /session/96d209e0-a12b-43ae-aa50-eff91550202d/window/current/size

The issue is caused in AbstractWebDriver when $rawResult is empty. It looks as though selenium emits an empty body for this request. Previously in 1.4.3 this would incorrectly attempt to parse this as json, but fail silently.

In 1.4.4 this will incorrectly attempt to parse this as json, but raise an error.

What should probably happen is that empty results aren't parsed at all, but left empty.

We are using selenium 2.41.0.

tractorcow pushed a commit to open-sausages/php-webdriver that referenced this issue Jun 30, 2017
@tractorcow
Copy link
Contributor Author

Fix with tests at #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant