Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from AWS basic authentication to DefaultAWSCredentialsProvide… #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shreepadangg
Copy link

@shreepadangg shreepadangg commented Nov 25, 2020

Changed from AWS basic authentication to DefaultAWSCredentialsProviderChain

@shreepadangg shreepadangg marked this pull request as draft November 25, 2020 08:02
@shreepadangg shreepadangg marked this pull request as ready for review November 25, 2020 08:04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your interest in this project, and for your pull request. Unfortunately, we must retain the option for credentials to be explicitly specified, as this gives us the flexibility to allow people to submit S3 connectors to their own buckets in the situation where they aren't in direct control of the Kafka Connect cluster itself. While having the DefaultAWSCredentialProvider as a fallback is a good idea - it cannot be the only way to provide credentials. Perhaps you could alter this to use the default provider chain if the explicit config options are not there?

@@ -5,3 +5,7 @@ target
.classpath
.java-version
*.iml
.DS_Store
s3/.DS_Store
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignore is smart enough to know that if you say you don't want .DS_Store, that you don't want it anywhere, so I don't think you need the last three lines here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants