Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-consecutive offsets as they might be present in compacted topics #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Astrac
Copy link

@Astrac Astrac commented May 6, 2021

No description provided.

@Astrac Astrac changed the title Support non-consecutive offsets as they might be present in compacted… Support non-consecutive offsets as they might be present in compacted topics May 6, 2021
@amrutha-shanbhag
Copy link
Contributor

@Astrac thanks for submitting the PR. We have added it into our internal work backlog. We should be able to address it latest by next month.

@h3nd24
Copy link

h3nd24 commented Jun 11, 2021

Hi @Astrac sorry it took us a while. For the change, I think the original condition of consecutive offset have some values in validating non-compacted topics. As such, I would propose to add a config property (e.g., in AwsStorageConnectorCommonConfig) instead to indicate whether the topic is compacted or not. If the topic is compacted, then we skip the check of consecutive offset. What do you think? We can even make your proposed behaviour to be the default, and make the consecutive validation as an opt in

Copy link

@h3nd24 h3nd24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it a configurable whether we want consecutive offset or not

@debaditya-netapp
Copy link

Hi @Astrac, Is this still being worked upon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants