Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: termination condition #266

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: termination condition #266

merged 1 commit into from
Nov 25, 2024

Conversation

WiemKhlifi
Copy link
Contributor

What:

Fix the termination condition in the JumanjiToGymWrapper.

@WiemKhlifi WiemKhlifi requested a review from sash-a November 25, 2024 14:57
@WiemKhlifi WiemKhlifi self-assigned this Nov 25, 2024
@sash-a sash-a changed the title fix: fix termination condition fix: termination condition Nov 25, 2024
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks!

@sash-a sash-a enabled auto-merge (squash) November 25, 2024 15:00
@sash-a sash-a merged commit 1ec8808 into main Nov 25, 2024
4 checks passed
@sash-a sash-a deleted the fix/fix_term_cond_gym branch November 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants