Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support to enable opt-in for forwarding exit spans without an entry span #684

Merged
merged 16 commits into from
Mar 25, 2024
Merged

added support to enable opt-in for forwarding exit spans without an entry span #684

merged 16 commits into from
Mar 25, 2024

Conversation

Angith
Copy link
Contributor

@Angith Angith commented Mar 20, 2024

Changes

  • Introduce an environment variable INSTANA_ALLOW_EXIT_AS_ROOT. Based on the environment variable, either the exit spans will be sent to the agent or suppressed.
  • Add unit tests for the above changes.

@Angith Angith requested a review from a team as a code owner March 20, 2024 11:50
@Angith Angith self-assigned this Mar 20, 2024
@Angith Angith added enhancement tekton_ci Add this label to start running Tekton pipelines labels Mar 20, 2024
@Angith Angith changed the title added support to anable opt-in for forwarding exit spans without an entry span added support to enable opt-in for forwarding exit spans without an entry span Mar 20, 2024
@Angith Angith removed the tekton_ci Add this label to start running Tekton pipelines label Mar 20, 2024
sanojsubran
sanojsubran requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@sanojsubran sanojsubran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the review comments

span.go Outdated Show resolved Hide resolved
util.go Outdated Show resolved Hide resolved
span_test.go Outdated Show resolved Hide resolved
span_test.go Outdated Show resolved Hide resolved
util_internal_test.go Outdated Show resolved Hide resolved
@Angith Angith requested a review from sanojsubran March 22, 2024 05:22
@Angith Angith added the tekton_ci Add this label to start running Tekton pipelines label Mar 22, 2024
@Angith Angith force-pushed the opt-in-exit-spans-core-changes branch from a5c631d to 343c1bb Compare March 25, 2024 05:05
sanojsubran
sanojsubran reviewed Mar 25, 2024
View reviewed changes
instrumentation_http_test.go Outdated Show resolved Hide resolved
instrumentation_http_test.go Outdated Show resolved Hide resolved
Angith and others added 3 commits March 25, 2024 16:26
@Angith @sanojsubran
Update instrumentation_http_test.go
1de5a11 
Co-authored-by: sanoj subran <sanoj.subran@ibm.com>
@Angith @sanojsubran
Update instrumentation_http_test.go
de4e2c0 
Co-authored-by: sanoj subran <sanoj.subran@ibm.com>
@Angith
code cleanup
cc3c3ab
@Angith Angith requested a review from sanojsubran March 25, 2024 11:34
sanojsubran
sanojsubran approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@sanojsubran sanojsubran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good work @Angith !

@Angith Angith merged commit 4b7a126 into main Mar 25, 2024
19 checks passed
@Angith Angith deleted the opt-in-exit-spans-core-changes branch March 25, 2024 15:46
@Angith Angith mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanojsubran sanojsubran sanojsubran approved these changes

@nithinputhenveettil nithinputhenveettil Awaiting requested review from nithinputhenveettil

Assignees

@Angith Angith

Labels
enhancement tekton_ci Add this label to start running Tekton pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Angith @sanojsubran