Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI process #721

Open
3 of 7 tasks
matiasgarciaisaia opened this issue Mar 8, 2024 · 0 comments
Open
3 of 7 tasks

Improve CI process #721

matiasgarciaisaia opened this issue Mar 8, 2024 · 0 comments
Labels
enhancement

Comments

@matiasgarciaisaia
Copy link
Member

matiasgarciaisaia commented Mar 8, 2024 •
edited
Loading

There are some issues with the new Github Actions based CI process that we should tackle:

  • NodeJS installation script adds 1:20 minute sleeps (to warn us it's deprecated)
  • NodeJS version is out of date and unsupported 🙃
  • Base Debian version is out of date and unsupported
  • mapcache and mapserver images are sharing a Docker repo (should have a different repo for each image)
  • Dependencies are getting downloaded on every build (we should either cache them or build an image with the base dependencies and another one on top with the app's code)
  • Dockerfile-dev is exactly the same as the first few steps of the build stage for the actual image (we should reuse the build stage, or a subset of it, for development and tests)
  • There's a weird loop to retry apt packages download & installation that doesn't make sense (probably due to old network issues between CircleCI and Debian repos).
matiasgarciaisaia added a commit that referenced this issue Mar 12, 2024
@matiasgarciaisaia
Unify Dockerfiles for app's prod & development
0498290 
Since the development image was basically a subset of the production
one, we now unify them in a multi-stage image.

See #721
matiasgarciaisaia added a commit that referenced this issue Mar 12, 2024
@matiasgarciaisaia
Stop retrying apt packages installation in Docker
62a817b 
The old retries were probably set up to workaround network issues in the
old CI process. We don't need them now.

See 500369f

See #721
matiasgarciaisaia added a commit that referenced this issue Mar 12, 2024
@matiasgarciaisaia
Split mapcache & mapserver Docker repos
45e9ac1 
Instead of sharing a repository, make each of them have its own.

See #721
@matiasgarciaisaia matiasgarciaisaia mentioned this issue Mar 12, 2024
Merged
matiasgarciaisaia added a commit that referenced this issue Mar 19, 2024
@matiasgarciaisaia
Improve CI process (#723)
ce906de 
* Unify Dockerfiles for app's prod & development

Since the development image was basically a subset of the production
one, we now unify them in a multi-stage image.

See #721

* Stop retrying apt packages installation in Docker

The old retries were probably set up to workaround network issues in the
old CI process. We don't need them now.

See 500369f

See #721

* Split mapcache & mapserver Docker repos

Instead of sharing a repository, make each of them have its own.

See #721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matiasgarciaisaia