Disable downloading incentives #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
approved these changes
Feb 22, 2021
matiasgarciaisaia
added a commit
that referenced
this pull request
Jul 16, 2024
Was laying there since #1842
matiasgarciaisaia
added a commit
that referenced
this pull request
Jul 25, 2024
Was laying there since #1842
matiasgarciaisaia
added a commit
that referenced
this pull request
Jul 30, 2024
* Fix unrelated typing warning Was laying there since #1842 * Refactor API preparing to receive more survey opts Will need this to duplicate a survey. See #2351 * Add endpoint to duplicate surveys I still have to check if it works with already-running surveys, and panel surveys and other configurations. See #2351 * Expose survey duplicate feature from UI See #2351 * Prevent duplicating Panel Surveys See #2351 * Test duplication of running surveys See #2351 * Test duplicate surveys don't have exit status See #2351 * Fix: SurveyCanceller tests avoid the Supervisor The tests were unnecessarily coupled to the Supervisor. We still have lots of improvements to do, but this should make the tests pass. See #2337 See #2147 Co-authored-by: Ana Pérez Ghiglia <aghiglia@manas.tech> * Fix: add Flow types to new action See #2351 * Don't over-engineer the double-click prevention * Test copying standard quex * Fix running survey duplication test * Comment how quota_buckets_definitions work * Extract common survey creation behaviour See #2351 See #2354 --------- Co-authored-by: Ana Pérez Ghiglia <aghiglia@manas.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation 🥕
Since #1837 the end-users can upload files with respondent ids.
Disable downloading the incentive file to protect the respondents' anonymity.
Fix #1834
The technical debt 🐌
The survey - respondent groups UI update design is weak. It's an old technical debt. See this comment.
This was the origin of this workaround, in order to update the survey UI after updating the respondent group.
How it looks 📷