Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: can't build Broker image anymore #905

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

ysbaddaden
Copy link
Contributor

No description provided.

Copy link
Member

@matiasgarciaisaia matiasgarciaisaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply awesome! 🎉

I've triggered this Action to check the build actually works in the CI 👍

Just for reference, the current rebar master version on top of which to apply the patch is https://github.com/rebar/rebar/tree/b6d309417c502ca243f810e5313bea36951ef038

@ysbaddaden
Copy link
Contributor Author

@matiasgarciaisaia Maybe we should fork rebar/rebar as manastech/rebar and add the patch to it, so we won't lose or forget it.

@matiasgarciaisaia
Copy link
Member

@ysbaddaden That's an option, sure.

Do you know if migrating to a supported rebar version (rebar3?) implies much more effort?

@ysbaddaden
Copy link
Contributor Author

We should ask @ggiraldez about that. Reading https://rebar3.org/docs/tutorials/from_rebar2_to_rebar3/ it seems not too hard but non trivial (for non Erlang developers such as me). It seems migrating to rebar3 means migrating to hex.pm?

@matiasgarciaisaia
Copy link
Member

I'll merge this one, we can then decide what to do regarding a long-term solution to rebar.

@matiasgarciaisaia matiasgarciaisaia merged commit f60ba5a into master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants