Skip to content

Commit

Permalink
removing redundant setActionGroupAlertContent setter functions
Browse files Browse the repository at this point in the history
Signed-off-by: Ash Evans <ash.evans@ibm.com>
  • Loading branch information
aevo98765 committed Oct 15, 2024
1 parent 2fccd68 commit 044054f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,15 @@ import { DropdownList } from '@patternfly/react-core/dist/dynamic/components/Dro
import { MenuToggle, MenuToggleElement } from '@patternfly/react-core/dist/dynamic/components/MenuToggle';
import DownloadYaml from '../DownloadYaml/DownloadYaml';
import DownloadAttribution from '../DownloadAttribution/DownloadAttribution';
import { ActionGroupAlertContent, KnowledgeFormData } from '..';
import { KnowledgeFormData } from '..';
import DownloadIcon from '@patternfly/react-icons/dist/esm/icons/download-icon';

interface Props {
knowledgeFormData: KnowledgeFormData;
setActionGroupAlertContent: React.Dispatch<React.SetStateAction<ActionGroupAlertContent | undefined>>;
githubUsername: string | undefined;
}

export const DownloadDropdown: React.FunctionComponent<Props> = ({ knowledgeFormData, setActionGroupAlertContent, githubUsername }) => {
export const DownloadDropdown: React.FunctionComponent<Props> = ({ knowledgeFormData, githubUsername }) => {
const [isOpen, setIsOpen] = React.useState(false);

const onToggleClick = () => {
Expand Down
6 changes: 1 addition & 5 deletions src/components/Contribute/Knowledge/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -587,11 +587,7 @@ export const KnowledgeForm: React.FunctionComponent<KnowledgeFormProps> = ({ kno
resetForm={resetForm}
/>
)}
<DownloadDropdown
knowledgeFormData={knowledgeFormData}
setActionGroupAlertContent={setActionGroupAlertContent}
githubUsername={githubUsername}
/>
<DownloadDropdown knowledgeFormData={knowledgeFormData} githubUsername={githubUsername} />
<ViewDropdown knowledgeFormData={knowledgeFormData} githubUsername={githubUsername} />
<Button variant="link" type="button" onClick={handleCancel}>
Cancel
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,15 @@ import { DropdownList } from '@patternfly/react-core/dist/dynamic/components/Dro
import { MenuToggle, MenuToggleElement } from '@patternfly/react-core/dist/dynamic/components/MenuToggle';
import DownloadYaml from '../DownloadYaml/DownloadYaml';
import DownloadAttribution from '../DownloadAttribution/DownloadAttribution';
import { ActionGroupAlertContent, SkillFormData } from '..';
import { SkillFormData } from '..';
import DownloadIcon from '@patternfly/react-icons/dist/esm/icons/download-icon';

interface Props {
skillFormData: SkillFormData;
setActionGroupAlertContent: React.Dispatch<React.SetStateAction<ActionGroupAlertContent | undefined>>;
githubUsername: string | undefined;
}

export const DownloadDropdown: React.FunctionComponent<Props> = ({ skillFormData, setActionGroupAlertContent, githubUsername }) => {
export const DownloadDropdown: React.FunctionComponent<Props> = ({ skillFormData, githubUsername }) => {
const [isOpen, setIsOpen] = React.useState(false);

const onToggleClick = () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/Contribute/Skill/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ export const SkillForm: React.FunctionComponent<SkillFormProps> = ({ skillEditFo
resetForm={resetForm}
/>
)}
<DownloadDropdown skillFormData={skillFormData} setActionGroupAlertContent={setActionGroupAlertContent} githubUsername={githubUsername} />
<DownloadDropdown skillFormData={skillFormData} githubUsername={githubUsername} />
<ViewDropdown skillFormData={skillFormData} githubUsername={githubUsername} />
<Button variant="link" type="button" onClick={handleCancel}>
Cancel
Expand Down

0 comments on commit 044054f

Please sign in to comment.