Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor validation in the Knowledge submission form #94

Closed
aevo98765 opened this issue Jul 26, 2024 · 1 comment
Closed

Refactor validation in the Knowledge submission form #94

aevo98765 opened this issue Jul 26, 2024 · 1 comment
Assignees
@aevo98765
Labels
tech debt

Comments

@aevo98765
Copy link
Member

Validation code is repeated multiple times within the src/components/knowledge/index.tsx file.

Validation on the question and answer pair input needs to be implemented. e.g. minimum 5 pairs and no more than 2300 words in each pair. https://github.com/instructlab/taxonomy?tab=readme-ov-file#getting-started-with-knowledge-contributions.
@aevo98765
Copy link
Member Author

Consider the changes here and ensure up to date validation -> #93

@aevo98765 aevo98765 self-assigned this Jul 31, 2024
vishnoianil added a commit that referenced this issue Aug 19, 2024
@vishnoianil
Merge pull request #111 from aevo98765/issue/#94/refactor-the-knowled…
5d85c09 
…ge-submission-form

Issue/#94/refactor the knowledge submission form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aevo98765 aevo98765

Labels
tech debt
Projects
UI
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aevo98765