Feature: add the ability for a user to amend a commit #24
Conversation
Details in instructlab#15 Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
- Cleaned up submissions to better reflect the taxonomy schemas. - Changed task_details to submission_summary to be used for the commit title. Add a character limit to that summary field to adhere to commit title length best practice. - Fixed the dco format. - Set revision field in the skill attribution to '-' Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
nerdalert
force-pushed
the
feat-edit-prs
branch
2 times, most recently
from
1654e9b
to
0f63f77
Compare
|
View the code running here for testing. Please try it if you have the time. The test repo CI will label the PR and it will populate in the dashboard once you submit it. You can from there edit it. http://34.229.17.203:4000/ Here is a populated dashboard: Modal popup: Edit Submission: |
- Also adds a pop modal for viewing the current yaml config - Replace the upstream repo .envs with public nextjs variables that are prefixed with `NEXT_PUBLIC_` Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
.env.example
Outdated
| @@ -12,3 +12,5 @@ GITHUB_TOKEN=<TOKEN FOR OAUTH INSTRUCTLAB MEMBER LOOKUP> | |||
| TAXONOMY_REPO_OWNER=<GITHUB_ACCOUNT> | |||
| TAXONOMY_REPO=<REPO_NAME> | |||
There was a problem hiding this comment.
Are TAXONOMY_REPO_OWNER and TAXONOMY_REPO still in use after this PR?
There was a problem hiding this comment.
@toraponibm thanks for catching that. I had to switch the ENVs for be prefixed with NEXT_PUBLIC_ for them to be accessible by the client side in NextJs.
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
|
I tested it to work on the CI environment. I do see a couple usability issues. Not sure if I should report them or it's assumed that it's a WIP and things are not polished yet. Given the scope is purely about amend, this LGTM. |
@juancappi looking to merge it. Throw them at me. We can do them on follow up smaller PRs. Not a huge fan of big PRs like this but since it's a feature it sprawled on me. Happy to open the issues, ty for spinning it up! |
Details in #15
Closes #15
Closes #29