Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote js-yaml from devDependencies #68

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Gregory-Pereira
Copy link
Contributor

@Gregory-Pereira Gregory-Pereira commented Jul 11, 2024

Signed-off-by: greg pereira <grpereir@redhat.com>
@vishnoianil
Copy link
Member

Unfortunately we can verify if this works or not by merging it. So let's merge and see if the job passes.

@vishnoianil vishnoianil changed the title removing omit dev from install promote js-yaml from devDependencies Jul 11, 2024
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit a58e3d1 into instructlab:main Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image publishing github workflow is broken
2 participants