Course upload improvements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,11 @@ def post(method, path, params = {}) | |||
| end | |||
| body = res.body | |||
| end | |||
| if path.respond_to? :read | |||
There was a problem hiding this comment.
This was super confusing for me to read through the first time, perhaps we can rename the path variable to something like file? Just thinking for later understandability.
- Allow uploading courses directly with one method call - Course files can now be passed in as any IO-like object
javawizard
force-pushed
the
course-upload-improvements
branch
from
d6d1983 to
64e53ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow uploading courses directly with one method call
Course files can now be passed in as any IO-like object