Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run port forwarder and reverse proxy in order #24

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Run port forwarder and reverse proxy in order #24

merged 1 commit into from
Oct 21, 2019

Conversation

int128
Copy link
Owner

@int128 int128 commented Oct 21, 2019

This changes to run the components in order.

Run a port forwarder and reverse proxy, and waits for them, as follows:

  1. Run a port forwarder.
  2. When the port forwarder is ready, run a reverse proxy.
  3. When the reverse proxy is ready, open the browser.

When the context is canceled,

  • Shut down the port forwarder.
  • Shut down the reverse proxy.

@codecov-io
Copy link

Codecov Report

Merging #24 into master will increase coverage by 9.09%.
The diff coverage is 95.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   77.27%   86.36%   +9.09%     
==========================================
  Files           1        1              
  Lines          44       88      +44     
==========================================
+ Hits           34       76      +42     
- Misses          6        7       +1     
- Partials        4        5       +1
Impacted Files Coverage Δ
pkg/usecases/authproxy/auth_proxy.go 86.36% <95.08%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da70998...70332f7. Read the comment docs.

@int128 int128 merged commit 7e32955 into master Oct 21, 2019
@int128 int128 deleted the refactor branch October 21, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants