Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated selfLink dependency #93

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Remove deprecated selfLink dependency #93

merged 1 commit into from
Aug 14, 2020

Conversation

int128
Copy link
Owner

@int128 int128 commented Aug 14, 2020

This will remove dependency of deprecated selfLink field which will be removed in Kubernetes v1.20.0. Fix #89.

@codecov-commenter
Copy link

Codecov Report

Merging #93 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   83.17%   83.33%   +0.15%     
==========================================
  Files           1        1              
  Lines         107      108       +1     
==========================================
+ Hits           89       90       +1     
  Misses         10       10              
  Partials        8        8              
Impacted Files Coverage Δ
pkg/authproxy/auth_proxy.go 83.33% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e17185...7896ff2. Read the comment docs.

@int128 int128 merged commit 37915d8 into master Aug 14, 2020
@int128 int128 deleted the remove-selflink branch August 14, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selfLink field will be removed in Kubernetes v1.20.0
2 participants