Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Inline Tasks Support #5

Closed
integral-dw opened this issue Mar 6, 2020 · 4 comments
Closed

Improving Inline Tasks Support #5

integral-dw opened this issue Mar 6, 2020 · 4 comments
Assignees
@integral-dw
Labels
enhancement New feature or request

Comments

@integral-dw
Copy link
Owner

integral-dw commented Mar 6, 2020 •
edited
Loading

I confess that I hardly use inline tasks at all, so I'm not requesting this. However, cleaning up the stars from inline tasks would be a very cool feature. So if you're looking for an excuse to do it, you can say that someone actually commented on it. ;) Maybe a nice idea for 1.1?

Originally posted by @alphapapa in #3 (comment)

I thought it may be a good idea to make this it's own issue. I'll get to it sometime soon!
@integral-dw integral-dw self-assigned this Mar 6, 2020
@integral-dw integral-dw added the enhancement New feature or request label Mar 6, 2020
@integral-dw
Copy link
Owner Author

integral-dw commented Mar 18, 2020 •
edited
Loading

Okay, so for now the only feature planned for inlinetasks is adding the leading bullet for org-inlinetasks, meaning the first "*" is displayed in a special way. This includes:

  • honoring the value of org-inlinetask-show-first-star
  • using a special face for the first star, if displayed (by default, org-warning)
  • setting org-indent-inlinetask-first-star buffer-locally such that Org Indent users experience a consistent behavior

Sounds good?

integral-dw added a commit that referenced this issue Mar 18, 2020
@integral-dw
Updating README to address issue #5.
0d18d5a 
Also, only the *first* bullet of an inlinetask is special, not the second.
@integral-dw
Copy link
Owner Author

integral-dw commented Apr 17, 2020 •
edited
Loading

Alrighty, this took long enough to put on the schedule, but I believe this is gonna be addressed in v1.5.0 v1.4.0.

@integral-dw
Copy link
Owner Author

Man, that was kind of a trip to implement, there was actually a surprising amount of complexity to consider, since Indent, Inlinetask and Superstar all interact, with Superstar having to mess with both packages unobtrusively. I think this will require some testing.

integral-dw added a commit that referenced this issue Aug 17, 2020
@integral-dw
Honor ‘org-inlinetask-show-first-star’.
4b4ddd7 
Added various functions and custom variables to accomodate new
feature.  This is the first step towards addressing issue #5.

Moved org-superstar-remove-leading-stars to a more appropriate
location.
@integral-dw
Copy link
Owner Author

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@integral-dw integral-dw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@integral-dw