Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paths filter to subscriptions #1185

Open
mkj28 opened this issue Apr 22, 2021 · 2 comments
Open

Add paths filter to subscriptions #1185

mkj28 opened this issue Apr 22, 2021 · 2 comments

Comments

@mkj28
Copy link

mkj28 commented Apr 22, 2021

Similar to #384 but for paths

Our use case is we'd like to let our design/docs team know when a change modifying paths: ["**.jsx", "**.tsx"] is merged. We are currently using in-house github actions for this. Would be nice to add support for path filters to official so that we can subscribe channels to path-based filters.

@ashokirla ashokirla added the type:feature Feature request label Apr 26, 2021
@ashokirla
Copy link
Contributor

Thanks for the feedback. We have plans to build support for custom filters for notifications. We will look into this as part of it.

@sushmita-m sushmita-m added Feature request and removed type:feature Feature request labels May 19, 2021
@taw123
Copy link

taw123 commented May 22, 2021

Adding comment I JUST posted in previous thread for some additional clarity on how this might function....

Any progress here? I hate adding a"me too" tag here but...

I'm trying to track new issue related to a Repo I DON'T own so I can't add the GitHub Action I found elsewhere that runs at label creation and allows for notice on label if added to the repo issue-label-notifier). This was actually found in a similar request for label subscription in GitHub, that is still open tracing back to 2016... Automatically subscribe to an issue by label or a set of labels

Using the command described HERE I would like to follow ONLY specific label(s) in the Home Automation repo that are associated with the integrations I use....

Sounds simple enough... but to date after searching and reading this thread, I don't see a way to subscribe/follow say home-assistant/core +label:"integration: shelly" +label:"integration: apple_tv" The following command would seem like it SHOULD work IF the command would actually provided notification of ALL NEW AND MODIFIED issues with label(s) found in list...
/github subscribe home-assistant/core +label:"integration: shelly" +label:"integration: apple_tv"

Additional, WHEN this DOES (hopefully) work, can one make changes in the future by simply adding/removing labels from a potential CURRENT/pre-existing subscription list? (i.e. will the following result in 1 or 3 subscribed labels?)
/github subscribe home-assistant/core +label:"integration: shelly" +label:"integration: apple_tv"
/github subscribe home-assistant/core +label:"integration: additional_new_label"

IDEALLY the result of the 2 separate commands above would be a subscription to the repo home-assistant/core for the 3 labels: integration: shelly, apple_tv, additional_new_label

Correspondingly then, one would hope that the 2 commands:
/github subscribe home-assistant/core +label:"integration: shelly" +label:"integration: apple_tv" +label:"integration: additional_new_label"

/github unsubscribe home-assistant/core +label:"integration: additional_new_label"

SHOULD produce a subscription list for home-assistant/core to just 2 labels labels: integration: shelly and integration: apple_tv. Correct?

Thanks for any help here.
--Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants