-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribe to certain labels only #384
Comments
We would love this to be able to filter out Greenkeeper PRs from polluting our Slack channels. A cursory glance at the code makes it seem like this would be fairly straightforward to implement. If I worked on a PR, would this feature be accepted? What would the preferred command syntax be? |
Can you provide a link to specific lines you had in mind? Or you already started work in this feature? |
I have not started on this. But from glancing at the code, it seems that it already fetches the labels for PRs/issues here and here and includes them on the objects passed around. (I think this is just so they can be included in Slack messages). So, roughly, I was imaging you'd pass in optional label filters to subscribe/unsubscribe here and right around... here (and in the analogous spot for issues) you'd exit early (not send a message) if the PR matches blacklisted labels? People may want both the ability to whitelist labels and to blacklist labels... Hrm. |
^ Bump this. When working on a monorepo type project it's useful for feature teams/pods to only subscribe to their specific labels. |
Monorepo here as well. This currently makes GH Slack Notifications unusable because of the traffic. Even for our other repos, a more fine-grained selection of notifications would me this immensely useful, for example only post if a certain tag is set (e.g READY FOR REVIEW) We currently deploy our own bot to work around this limitation: https://pspdfkit.com/blog/2018/reviewbot/ (We cant run our own bot for filtering - that’s too complex) |
I've got a similar issue, we have a monorepo for our API/web but we label PRs for our the API that concern our internal tools, it'd be great to have them emit into a specific channel |
Same here, we have monorepo as well. It would be cool to be able to setup something like this on Slack: |
We really need this too. |
Also need. |
This will be cool |
Also need. |
Would be very helpful for a monolithic codebase where you want to filter front-end/back-end PRs seperately |
Would love this, both for monorepo use cases but also to filter out automatic/bot PRs that become too noisy in some projects (and that all have a specific label) |
Our use case is for our designers to be informed on their slack channels when we label an issue with |
+1 we also need this....any update as to whether this will be provided? |
That would be great! Please make it happen 🤞 |
+1 for this feature. |
+1 This would be extremely helpful and make this integration work better with our teams' workflow. |
This is a great idea and my team will definitely benefit from having this option! Bump ^ |
+1! |
➕ 1️⃣ |
Everybody who is interested in sharing their thoughts about a future filter syntax that allows AND/OR combinations, feel free to add your two cents in #913 |
Filtering by a "required-label" is now possible 🎉 .
|
Hi @scepticulous thanks so much for doing this! I'm currently running into issues subscribing to labels with whitespace. I'm getting this error when entering the command |
I assume there is a problem with the quotes or the whitespace. Can you try typing the double quotes Here is my example: Command |
Thanks again for tackling this! I'm getting the same error using double or single ASCII quotes. My command was
FWIW, the repo was private, not sure if that matters, but the GitHub Slack integration can view things in that repo |
my new theory is that my github integration does not have the most recent updates. I've tried updating slack, reinstalling the integration, and restarting slack to no avail. |
@DeMarko Thanks for sharing your exact command. Your example is actually not using ASCII double-quotes (ASCII 34). Here is the difference: However, that is hard to spot, confusing and annoying. In addition to
|
oh woah! Thanks for spotting that, I had no idea Slack (or maybe my OS?) was doing "smart" Unicode quotes |
Hey there, thanks for this awesome feature. Just wondering. Is it entirely impossible to subscribe to multiple labels? When I run Then I tried I would very much like to filter issues on multiple labels. Should I open a new issue to propose this and describe my usecase? |
I would expect to get a notification if the required label I'm filtering on, was added after the issue was initially created, e.g.:
I am only subscribed to the |
@efung Did you ever find a workaround for this? I am finding the same issue with our workflow. We're using a github action to set the labels automatically, so they aren't set until after PR creation. |
No, I haven't. |
It seems that |
Does this support multiple labels, or just one? |
Any progress here? I hate adding a"me too" tag here but... I'm trying to track new issue related to a Repo I DON'T own so I can't add the GitHub Action I found elsewhere that runs at label creation and allows for notice on label if added to the repo issue-label-notifier). This was actually found in a similar request for label subscription in GitHub, that is still open tracing back to 2016... Automatically subscribe to an issue by label or a set of labels Using the command described HERE I would like to follow ONLY specific label(s) in the Home Automation repo that are associated with the integrations I use.... Sounds simple enough... but to date after searching and reading this thread, I don't see a way to subscribe/follow say home-assistant/core +label:"integration: shelly" +label:"integration: apple_tv" The following command would seem like it SHOULD work IF the command would actually provided notification of ALL NEW AND MODIFIED issues with label(s) found in list... Additional, WHEN this DOES (hopefully) work, can one make changes in the future by simply adding/removing labels from a potential CURRENT/pre-existing subscription list? (i.e. will the following result in 1 or 3 subscribed labels?) IDEALLY the result of the 2 separate commands above would be a subscription to the repo home-assistant/core for the 3 labels: integration: shelly, apple_tv, additional_new_label Correspondingly then, one would hope that the 2 commands:
SHOULD produce a subscription list for home-assistant/core to just 2 labels labels: integration: shelly and integration: apple_tv. Correct? Thanks for any help here. |
I'd also like to know if multiple labels are supported. This is a quite simple and extremely useful feature. |
Any news on the multi-label ? |
Plus one on the multi label question -- this and or a custom query would be a huge help for me |
At my day job we use a mono-repo structure too and getting bombarded with notifications for all pulls has stopped us being able to use this plugin too. I decided to fix the problem myself and created https://www.pullmate.io/ 🎉 which lets you subscribe to notifications for pulls only from specified sub-directories: e.g. running I was wondering if this helps mitigate the need to filter by label? or is that still required? |
On my side, I am not allowed to filter on label with an |
This feature seems really really useful. Is there any plan to make this available for GitHub Enterprise Server users? |
What happened to pullmate? |
Is it possible to filter out when a label is present? |
I'm a member of a Slack channel dedicated to a specific feature of a repo that covers a wide variety of features. Right now we have an internal Hubot to filter down to a specific label and then post messages to the channel.
It'd be cool if this official integration could replace our internal by allow subscribing to only issues/PRs that have a specific label instead of the entire repo.
The text was updated successfully, but these errors were encountered: