Add pagination to github_external_groups data source (#1688)

Fixes #1687
integrations · May 18, 2023 · 49b2376 · 49b2376
1 parent ce50fe0
commit 49b2376
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/github/data_source_github_external_groups.go b/github/data_source_github_external_groups.go
@@ -48,9 +48,20 @@ func dataSourceGithubExternalGroupsRead(d *schema.ResourceData, meta interface{}
 	ctx := context.WithValue(context.Background(), ctxId, d.Id())
 	opts := &github.ListExternalGroupsOptions{}
 
-	externalGroups, _, err := client.Teams.ListExternalGroups(ctx, orgName, opts)
-	if err != nil {
-		return err
+	externalGroups := new(github.ExternalGroupList)
+
+	for {
+		groups, resp, err := client.Teams.ListExternalGroups(ctx, orgName, opts)
+		if err != nil {
+			return err
+		}
+
+		externalGroups.Groups = append(externalGroups.Groups, groups.Groups...)
+
+		if resp.NextPage == 0 {
+			break
+		}
+		opts.Page = resp.NextPage
 	}
 
 	// convert to JSON in order to martial to format we can return