Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner Group Selected Repositories IDs in constant drift #969

Closed
Vladyslav-Miletskyi opened this issue Nov 8, 2021 · 1 comment · Fixed by #970
Closed

Runner Group Selected Repositories IDs in constant drift #969

Vladyslav-Miletskyi opened this issue Nov 8, 2021 · 1 comment · Fixed by #970

Comments

@Vladyslav-Miletskyi
Copy link
Contributor

When the number of selected repositories is higher than 30 - the resource is in constant drift.

Affected Resource(s)

github_actions_runner_group

Terraform Configuration Files

resource "github_actions_runner_group" "project" {
  name                    = var.group_name
  visibility              = "selected"
  selected_repository_ids = values(data.github_repository.this)[*].repo_id
}

Expected Behavior

Once applied, there will be no drift.

Actual Behavior

Terraform shows drift for length(selected_repositories) - 30 repos

Steps to Reproduce

  1. terraform apply
    2.terraform apply
@Vladyslav-Miletskyi
Copy link
Contributor Author

client.Actions.ListRepositoryAccessRunnerGroup, used for repos listing, is returning a paginated response with, by default, 30 repos per response. One should iterate thru all pages, in order to get all repos and get rid of this issus

Vladyslav-Miletskyi added a commit to Vladyslav-Miletskyi/terraform-provider-github that referenced this issue Nov 8, 2021
jcudit pushed a commit that referenced this issue Nov 22, 2021
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant